Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Documentation Main Page #95

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

tdcox
Copy link
Contributor

@tdcox tdcox commented Nov 18, 2022

Signed-off-by: Terry Cox terry@bootstrap.je

Changes

  • Implemented a descriptive landing page for the documentation, with context and description
  • Added icons to docs
  • Disabled auto-generated page list

PR is 'look and feel' only and does not impact specification content.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Copy link
Contributor

@e-backmark-ericsson e-backmark-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that introductory text is added to the index page

@afrittoli
Copy link
Contributor

afrittoli commented Nov 21, 2022

Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, it looks really good.
Only a couple of comments.
For TOCs we should use the existing tool.

@afrittoli
Copy link
Contributor

Note: the requirement for approval on GitHub actions is only for first-time contributors, so once this is merged tests should run automatically on your PR 🙏

@tdcox
Copy link
Contributor Author

tdcox commented Nov 22, 2022

@afrittoli Looks like it is stuck because the first commits weren't getting cryptographically signed. Can you override, or should I create a new PR?

@afrittoli
Copy link
Contributor

afrittoli commented Nov 22, 2022

@afrittoli Looks like it is stuck because the first commits weren't getting cryptographically signed. Can you override, or should I create a new PR?

I can override if you prefer.

You would not need to create a new PR to fix the issue, though, you could sign your past commits or since they need to be squashed anyways, you could squash them locally, sign your commit and push:

# Rebase the last 5 commits, mark all commits but one with "s" for squash
git rebase -i HEAD~5
# Sign the resulting commit
git commit -s --amend
# Push to your PR branch
git push <your-remote-name> refresh-1b --force

Let me know if you want to try that or if you prefer I merge right away 🙏

Signed-off-by: Terry Cox <terry@bootstrap.je>
@tdcox
Copy link
Contributor Author

tdcox commented Nov 22, 2022

@afrittoli Cleaned up...

Copy link
Contributor

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates.

@afrittoli afrittoli merged commit 132d19f into cdevents:main Nov 22, 2022
@afrittoli afrittoli mentioned this pull request Nov 24, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants