-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of "Run" buttons? #19
Comments
Thanks, Beth, for raising this. I created the Run/Run(Modify) model as a safeguard against making unwanted changes, with the Run option intended to be a "dry run" for a module that makes changes to the project.
|
I think this looks good. I think we could disable the Are you sure message box. Maybe this is configurable? |
This looks promising to me. My impression is that I can't run modules in "Run" mode currently, if they are marked as modifying the database. So I guess I never actually got the benefit of the "dry run" mode. Anyway, I think this is a good idea. |
I don't think any of Ron's modules support doing a dry run, so you've been seeing a strict Modifies/Doesn't-Modify dichotomy. For development and testing of modues, and for processes that might be a bit 'scary' to run on your project (e.g. Merge duplicates) it is helpful to be able to see what it will do before actually committing to it. (It is like Preview in Bulk Edit.) Actually, maybe the term 'preview' would be clearer than 'dry run'... |
Yes, I really like your proposal, especially with the "switchable option", so you can still have "dry run" or "preview" for other kinds of modules. If you did all that you propose here, that would help immensely! |
Provide a new flag (simplifiedRunOps) that removes the dry-run/preview buttons. The messages are tailored to this mode. Also, doesn't warn about changes if none of the modules selected can make changes.
Fixed for 2.2.2. Also, if warnOnModify is True, then it now doesn't display the Are you sure? dialog if the module or modules don't make changes. |
It's not clear to me why we need both "Run" and "Run (Modify)". Couldn't FlexTools just figure out which one is needed? I'm inclined to tell users "just use "Run (Modify) all the time", but then it is annoying to have messages come up when they run it on a module that doesn't need it: "Changes disabled". That also feels unnecessary. It would be nice to have only "Run" and "Run All" and let the "modify" part be figured out internally.
While we're at it, it would be nice to be able to select a subset of the modules showing (contiguous or not), and be able to "Run all selected". But I'm not asking for six buttons..... I wonder if "Run all" could automatically run all showing modules, and the "Run" button could have the effect of running the selected modules. Actually, this is issue #13.
The text was updated successfully, but these errors were encountered: