Skip to content

Commit

Permalink
* Fixing #413 Wrong equalizer settings with not US locales (thanks to…
Browse files Browse the repository at this point in the history
… Massimo Pissarello)
  • Loading branch information
cdgriffith committed Mar 5, 2023
1 parent 253ade0 commit 2dc383e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Adding #422 Add ICQ and LA-ICQ for rigayas QSV (thanks to @bender1984)
* Fixing #398 audio and subtitles disabled when editing queue item (thanks to philblue1 and Don Gafford)
* Fixing #350 Unable to burn in subtitles (thanks to Maddie Davis)
* Fixing #413 Wrong equalizer settings with not US locales (thanks to Massimo Pissarello)
* Fixing QSV AV1 setting panel issues

## Version 5.1.0
Expand Down
2 changes: 0 additions & 2 deletions fastflix/encoders/common/setting_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def __init__(self, parent, main, app: FastFlixApp, *args, **kwargs):
self.labels = Box()
self.opts = Box()
self.only_int = QtGui.QIntValidator()
self.only_float = QtGui.QDoubleValidator()

def paintEvent(self, event):
o = QtWidgets.QStyleOption()
Expand Down Expand Up @@ -350,7 +349,6 @@ def _add_modes(self, recommended_bitrates, recommended_qps, qp_name="crf", add_q
self.widgets[f"custom_{qp_name}"] = QtWidgets.QLineEdit("30" if not custom_qp else str(qp_value))
self.widgets[f"custom_{qp_name}"].setFixedWidth(100)
self.widgets[f"custom_{qp_name}"].setEnabled(custom_qp)
self.widgets[f"custom_{qp_name}"].setValidator(self.only_float)
self.widgets[f"custom_{qp_name}"].textChanged.connect(lambda: self.main.build_commands())

if config_opt:
Expand Down
4 changes: 0 additions & 4 deletions fastflix/widgets/panels/advanced_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ def __init__(self, parent, app: FastFlixApp):
self.attachments = Box()
self.updating = False
self.only_int = QtGui.QIntValidator()
self.only_float = QtGui.QDoubleValidator()

self.layout = QtWidgets.QGridLayout()

Expand Down Expand Up @@ -228,17 +227,14 @@ def init_eq(self):
self.last_row += 1
self.brightness_widget = QtWidgets.QLineEdit()
self.brightness_widget.setToolTip("Default is: 0")
self.brightness_widget.setValidator(self.only_float)
self.brightness_widget.textChanged.connect(lambda: self.page_update(build_thumbnail=True))

self.contrast_widget = QtWidgets.QLineEdit()
self.contrast_widget.setToolTip("Default is: 1")
self.contrast_widget.setValidator(self.only_float)
self.contrast_widget.textChanged.connect(lambda: self.page_update(build_thumbnail=True))

self.saturation_widget = QtWidgets.QLineEdit()
self.saturation_widget.setToolTip("Default is: 1")
self.saturation_widget.setValidator(self.only_float)
self.saturation_widget.textChanged.connect(lambda: self.page_update(build_thumbnail=True))

self.add_row_label(t("Equalizer") + " ʘ", self.last_row)
Expand Down

0 comments on commit 2dc383e

Please sign in to comment.