Skip to content

Commit

Permalink
* Fixing #579 Missing Infos and no Mouse-Over info in Subs-Panel sinc…
Browse files Browse the repository at this point in the history
…e 5.7 (thanks to GeZorTenPlotZ)
  • Loading branch information
cdgriffith committed Jul 19, 2024
1 parent d156323 commit 9055b6e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

## Version 5.7.4

* Fixing $578 Missing code signing to FastFlix exec inside of the installer (thanks to Sam Katakouzinos)
* Fixing #579 Missing Infos and no Mouse-Over info in Subs-Panel since 5.7 (thanks to GeZorTenPlotZ)
* Fixing #578 Missing code signing to FastFlix exec inside of the installer (thanks to Sam Katakouzinos)
* Fixing #580 No Downmix key error on profile save (thanks to Hankuu)
* Fixing #581 Fastflix could not recognize hevc video containing hdr10plus metadata with recent ffmpeg build (thanks to alpha-0)

Expand Down
1 change: 1 addition & 0 deletions fastflix/models/encode.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class SubtitleTrack(BaseModel):
dispositions: dict = Field(default_factory=dict)
enabled: bool = True
long_name: str = ""
raw_info: Optional[Union[dict, Box]] = None


class AttachmentTrack(BaseModel):
Expand Down
7 changes: 5 additions & 2 deletions fastflix/widgets/panels/subtitle_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def __init__(self, app, parent, index, enabled=True, first=False):
# self.widgets.disposition.setCurrentIndex(dispositions.index("forced"))

self.setFixedHeight(60)
# self.widgets.title.setToolTip(self.subtitle.to_yaml())
self.widgets.title.setToolTip(sub_track.raw_info.to_yaml())
self.widgets.burn_in.setToolTip(
f"""{t("Overlay this subtitle track onto the video during conversion.")}\n
{t("Please make sure seek method is set to exact")}.\n
Expand Down Expand Up @@ -308,15 +308,18 @@ def new_source(self):
audio_end = len(self.app.fastflix.current_video.audio_tracks)
for index, track in enumerate(self.app.fastflix.current_video.streams.subtitle):
enabled = self.lang_match(track)
subtitle_type = subtitle_types.get(track.get("codec_name", "text"), "text")
self.app.fastflix.current_video.subtitle_tracks.append(
SubtitleTrack(
index=track.index,
outdex=audio_end + index + 1,
dispositions={k: bool(v) for k, v in track.disposition.items()},
burn_in=False,
language=track.get("tags", {}).get("language", ""),
subtitle_type=subtitle_types.get(track.get("codec_name", "text"), "text"),
subtitle_type=subtitle_type,
enabled=enabled,
long_name=track.get("codec_long_name", f"{t('Subtitle Type')}:{subtitle_type}"),
raw_info=track,
)
)

Expand Down

0 comments on commit 9055b6e

Please sign in to comment.