* Fixing #144 Remove HDR not working (thanks to Chad Johnson)

* Fixing thumbnail generation preview for videos with arib-std-b67 color transfer
cdgriffith · Dec 29, 2020 · ed41e85 · ed41e85
1 parent e6a145e
commit ed41e85
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/build_windows_7.yaml b/.github/workflows/build_windows_7.yaml
@@ -1,4 +1,4 @@
-name: Build executables for Windows
+name: Build executables for Windows 7 (legacy)
 on:
  push:
  branches: [ master, develop, build ]

diff --git a/CHANGES b/CHANGES
@@ -2,11 +2,13 @@
 
 ## Version 4.0.2
 
-* Fixing #135 color information wasn't passed through correctly
-* Fixing #143 by adding legacy windows builds with Python 3.8 for time being
+* Fixing #144 Remove HDR not working (thanks to Chad Johnson)
+* Fixing #135 color information wasn't passed through correctly (thanks to leonardyan)
+* Fixing #143 by adding legacy windows builds with Python 3.8 for time being (thanks to odignal)
 * Fixing queue breaks if there is an error during conversion
 * Fixing Remove HDR doesn't stay selected when returning item from queue
 * Fixing resolution doesn't stay after returning from queue
+* Fixing thumbnail generation preview for videos with arib-std-b67 color transfer
 
 ## Version 4.0.1
 

diff --git a/fastflix/widgets/main.py b/fastflix/widgets/main.py
@@ -1236,7 +1236,11 @@ def generate_thumbnail(self):
  ):
  settings["remove_hdr"] = True
 
- filters = helpers.generate_filters(custom_filters="scale='min(320\\,iw):-8'", **settings)
+ custom_filters = "scale='min(320\\,iw):-8'"
+ if self.app.fastflix.current_video.color_transfer == "arib-std-b67":
+ custom_filters += ",select=eq(pict_type\\,I)"
+
+ filters = helpers.generate_filters(custom_filters=custom_filters, **settings)
 
  preview_place = (
  self.app.fastflix.current_video.duration // 10