-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugReport - custom ffmpeg options/ffmpeg_extras - not appearing in raw commands / not being passed through #150
Labels
bug
Something isn't working
Comments
cdgriffith
added a commit
that referenced
this issue
Dec 31, 2020
* Fixing exact / fast time selector not working * Fixing subtitle burn in not working (for picture images) * Fixing that text based subtitles could show as being burned-in-able
Thanks for running down that issue, you were totally correct! I still need to fix FFmpeg extras being re-set after returned from queue, so for tonight just put out a beta with that (and other similar) fixes. https://github.com/cdgriffith/FastFlix/releases/tag/4.0.4b0 |
Thanks so much for looking at it already. I really like your app and appreciate the work you have/continue to put into it. |
Merged
cdgriffith
added a commit
that referenced
this issue
Jan 1, 2021
* Fixing #137 Should not be able to try and switch between encoders without a video (thanks to leonardyan) * Fixing #149 Cannot set subtitle disposition in 4.0+ (thanks to Zeid164) * Fixing #150 FFmpeg extras not able to be set (thanks to kipperdawn) * Fixing exact / fast time selector not working * Fixing subtitle burn in not working (for picture images) * Fixing that text based subtitles could show as being burned-in-able * Fixing HEVC tune did not put space after itself in command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using v4.0.x, hevc encoder. i tried passing in an extra command to ffmpeg via the custom ffmpeg options in the gui but noticed i couldnt see my params in the raw commands window. I then tried adding to the end of the custom bitrate (since it had a text field and now my command is passed through). Looking quickly at the code (i don't really know python), it looks like the help class (helpers.py) should be inserting the "extra" via generate_ending, however generate_all is not passing in the value to generate_ending... or i think this is what is happening.
eg...
generate_all
{
...
ending = generate_ending(
audio=audio,
subtitles=subtitles,
cover=attachments,
output_video=fastflix.current_video.video_settings.output_path,
)
...
}
header for generate_ending
def generate_ending(
audio,
subtitles,
cover="",
output_video: Path = None,
copy_chapters=True,
remove_metadata=True,
null_ending=False,
extra="",
**_,
):
ending = (
...
I could be way off though as i didn't do a deep look into the code and i don't really know python
thx
The text was updated successfully, but these errors were encountered: