Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Remove Metadata" only removes video metadata for Rigaya's hardware encoders #330

Closed
wynterca opened this issue Apr 17, 2022 · 2 comments
Closed

"Remove Metadata" only removes video metadata for Rigaya's hardware encoders #330

wynterca opened this issue Apr 17, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@wynterca
Copy link

The "Remove Metadata" option doesn't seem to do anything the tool tip says removes titles etc? I am usually encoding with NVencC, maybe that is not supported with that particular encoder?
@cdgriffith
Copy link
Owner

For the NVencC (and all rigaya's encoders) it will pass in --video-metadata clear vs --video-metadata copy (their docs). I do need to fix that tool tip, as it doesn't remove titles as there is the "Title" field on the left hand side now to set / unset that.

I just tried it, and seems to clear the Video Language, but doesn't clear container metadata (which is cleared when that option is selected with ffmpeg) Looks like I need to also provide just --metadata clear which I missed. Thanks for pointing it out!

@cdgriffith cdgriffith added the bug Something isn't working label Apr 17, 2022
@cdgriffith cdgriffith changed the title "Remove Metadata" doesn't seem to do anything "Remove Metadata" only removes video metadata for Rigaya's hardware encoders Apr 17, 2022
cdgriffith added a commit that referenced this issue Apr 24, 2022
@cdgriffith
* Fixing #330 "Remove Metadata" only removes video metadata for Rigay…
ce69aec 
…a's hardware encoders (thanks to wynterca)
@cdgriffith cdgriffith mentioned this issue Apr 24, 2022
Merged
cdgriffith added a commit that referenced this issue Apr 24, 2022
@cdgriffith
Version 4.9.0 (#328)
2770ca8 
* Adding #109 Support for AVC and HEVC QSV encoding with rigaya's QSVEncC (thanks to msaintauret)
* Adding #196 Support for AVC and HEVC Apple Videotoolbox encoder (thanks to Kay Singh)
* Adding #323 ignore errors options options for queue (thanks to Don Gafford)
* Adding #331 NVEncC API v10 Quality presets: P1 to P7 (thanks to Wontell)
* Fixing #321 dhdr10_opt not added for x265 commands (thanks to GizmoDudex)
* Fixing #327 FastFlix Duplicates encoding task and encodes same movie to infinity (thanks to Wontell)
* Fixing #324 NVEncC wrong Interlace Value set by FastFlix (thanks to Wontell)
* Fixing #278 FastFlix occasionally getting stuck on a single video in a queue (thanks to kamild1996)
* Fixing #330 "Remove Metadata" only removes video metadata for Rigaya's hardware encoders (thanks to wynterca)
* Fixing level was not being passed to hardware encoders
@cdgriffith
Copy link
Owner

Updated to provide both in https://github.com/cdgriffith/FastFlix/releases/tag/4.9.0, thanks for opening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @wynterca