fix: instantiate Ajv2020 for OAS 3.1 #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdimascio
approved these changes
Nov 10, 2024
|
Thanks will look to roll this into a new alpha release |
|
current latest alpha is express-openapi-validator@6.0.0-alpha.5 and includes this change
im very interested in feedeback regarding the validators oas3.1 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey, i was testing the version 6.0.0 alpha compliant with OAS 3.1 but i couldn't get this working fine with
unevaluatedPropertiesconstraint. I checked the code and it was missing the Ajv2020 in request validator.I changed a bit the structure by creating factories for the Ajv instance and also for the schema, both based on the openapi version. Let me know if it's not standard in the project.
Note: i don't know what's going on with codacy check, it's complaining about missing eslint config for some examples but i didn't change them.