Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency query to return tables if they are actually mviews #21

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

whit0694
Copy link
Contributor

Fixes #20

If a dependency's type is VIEW or MATERIALIZED VIEW then we can return it.

But if it's a TABLE then we only want to return it if that table is actually a mview, which we can find by looking for it in user_mviews

Fixes cdinger#20

If a dependency's type is `VIEW` or `MATERIALIZED VIEW` then we can return it.

But if it's a `TABLE` then we only want to return it if that table is
actually a mview, which we can find by looking for it in `user_mviews`
@cdinger cdinger merged commit 0c36e18 into cdinger:main Jul 18, 2024
1 check passed
@cdinger
Copy link
Owner

cdinger commented Jul 18, 2024

Thanks, @whit0694. I'm assuming you're encountering this on 19c. Can you verify?

This user_dependencies relation is turning out to be flakier than I expected. Hopefully there aren't too many more gnarly edge cases. But if there are, I'm sure you'll find them 😉

@whit0694
Copy link
Contributor Author

@cdinger Yeah, I was seeing this in a local container running 19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency sorter query can miss dependencies on mis-classified (?) objects
2 participants