Update to support LLVM 17 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate, and test files. Tests pass, though there is a warning about LLVMGetArrayLength being deprecated
LLVMGetArrayLength has been deprecated. The parameters are the same, but the return type has changed
Closed
|
Added another tweak -- I see in the LLVM 17 changelog that they removed constexpr |
|
CI passes, in my opinion this is good enough to merge, we can address stuff like NSW/NUW in a followup as you say |
|
NSW/NUW/Exact will be addressed in #56 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly going off of what changes #39 made
This is an initial supporting of LLVM 17 to keep it lighter. The API changes don't seem that substantial, though NSW/NUW/Exact flags are now accessible via the C API. That can be done in a follow-up. The only API change was using
LLVMGetArrayLength2when it's available, sinceLLVMGetArrayLengthis now deprecatedTested locally using LLVM 17.0.6 and llvm-sys 170.0.1. Will double-check CI when it runs
Other resources:
llvm-sysupgrade to LLVM 17