refactor(plus): Remove the spec nesting level on both input and output

[iliapolo]

Removed the need to specify various spec properties for both pre and post instantiation. Applies to all constructs that used to accept a pod spec.

Before

const deployment = new kplus.Deployment(this, text, {
  spec: {
    podSpecTemplate: {
      containers: [
        new kplus.Container({
          image: 'hashicorp/http-echo',
          args: [ '-text', text ]
        })
      ]
    }
  }
});
deployment.spec.podSpecTemplate.addContainer(...)

After

const deployment = new kplus.Deployment(this, text, {
  containers: [
    new kplus.Container({
      image: 'hashicorp/http-echo',
      args: [ '-text', text ]
    })
  ]
});
deployment.addContainer(...)

BREAKING CHANGE: spec was removed from all cdk8s+ constructs and that now have a flat structure. See Example for new usage.

• plus: Construct id's for deployment will change due to a latent bug that appended the word pod to them.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[iliapolo]

Latent copy-paste bug...this changes the generated deployment name which explains the changes in some snapshots.

[iliapolo]

See comment.

[eladb]

toKube maybe?

[iliapolo]

I can't :\

_toKube is already implemented with a different return value in PodSpec. See #347 (comment)

[iliapolo]

oh you mean just without the underscore?

[mergify]

Your pull request will be updated and merged automatically (do not update manually).

[iliapolo]

This felt right, letting this class be responsible for creating the template spec used by Job and Deployment. It did mean I have to change the name if we want to preserve a typed return value from these methods.

We can also make this class not extend PodSpec but rather compose it and then we can use the normal _toKube, but that felt a bit redundant.

[eladb]

Makes me think we need to rename all these toKube methods to their respective output type

Pull request has been modified.

[mergify]

Your pull request will be updated and merged automatically (do not update manually).

Pull request has been modified.

[mergify]

Your pull request will be updated and merged automatically (do not update manually).