-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add notice for lambda-layer-awscli #21
Conversation
data/notices.json
Outdated
"components": [ | ||
{ | ||
"name": "aws-cdk-lib.lambda_layer_awscli.Notice", | ||
"version": ">=2.x.y" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. This seems to be a use case where we don't want an upper bound on the version. Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the use case. Your question made me realize I should just be using the ^
notation. That works (or at least, the tests pass).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm now using a placeholder, which causes the build to fail, until we know what version of aws-cdk-lib the relevant change is going out in.
2.42 is a placeholder! This will be changed before merge. This commit is to see if the format passes the tests.
This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label. |
Closing this pull request as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label. |
Create a CLI notice for when dynamically loading the asset for lambda-layer-awscli fails.