Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: notice for https://github.com/aws/aws-cdk/issues/27240 #318

Merged
merged 4 commits into from
Sep 25, 2023
Merged

chore: notice for https://github.com/aws/aws-cdk/issues/27240 #318

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14d266b
add notice to notices.json
sumupitchayan Sep 21, 2023
12cf6a0
Update data/notices.json
sumupitchayan Sep 22, 2023
36b9c5e
Update data/notices.json
sumupitchayan Sep 22, 2023
d824fee
rico's suggestion, make it clear env is python specifically
sumupitchayan Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions data/notices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,18 @@
}
],
"schemaVersion": "1"
},
{
"title": "ecs breaking change renaming prop in ContainerImage.fromEcrRepository",
sumupitchayan marked this conversation as resolved.
Show resolved Hide resolved
"issueNumber": 27240,
"overview": "Renaming a prop in ContainerImage.fromEcrRepository function introduces a breaking change, not for typescript users, but for other languages that require specifying the property name when calling the function.",
sumupitchayan marked this conversation as resolved.
Show resolved Hide resolved
"components": [
{
"name": "aws-cdk-lib.aws-ecs.ContainerImage.fromEcrRepository",
sumupitchayan marked this conversation as resolved.
Show resolved Hide resolved
"version": "2.96.0"
}
],
"schemaVersion": "1"
}
]
}