fix: assembly fails check for minor version differences #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now allow use of any version within the same major version.
scanlonp
requested changes
Aug 13, 2024
lib/manifest.ts
Outdated
| // first validate the version should be accepted. | ||
| if (semver.gt(actual, maxSupported) && !options?.skipVersionCheck) { | ||
| // first validate the version should be accepted. all versions within the same minor version are fine | ||
| if (maxSupported !== semver.major(actual) && !options?.skipVersionCheck) { |
There was a problem hiding this comment.
Did this allow lower major versions before? Now it will be confined to only the specific major version.
Is that what we want, or do we still want to do a greater than check but just on the major version?
There was a problem hiding this comment.
follow up nit: if we are just limiting the version to a single major version, the "maximum version supported" language does not have much meaning any more
There was a problem hiding this comment.
I suppose we can allow lower but it doesn't actually make a ton of sense to do so. However, we only ever checked for higher before so I'll stick with that for now and we can revisit it later.
scanlonp
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow use of any version within the same major version.
Fixes #