Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure SNS topics to receive stack events on the Stack construct #29

Merged
merged 2 commits into from
Sep 18, 2024
Merged

feat: configure SNS topics to receive stack events on the Stack construct #29

merged 2 commits into from
Sep 18, 2024

Conversation

comcalvi
Copy link
Contributor

@comcalvi comcalvi commented Aug 14, 2024 •
edited
Loading

Adds SNS notification ARNs to the cloud-assembly-schema. Necessary for aws/aws-cdk#31107.

@comcalvi comcalvi mentioned this pull request Sep 10, 2024
Merged
1 task
@mergify mergify bot merged commit ae50133 into main Sep 18, 2024
12 checks passed
@mergify mergify bot deleted the comcalvi/notification-arns branch September 18, 2024 06:46
@iliapolo iliapolo mentioned this pull request Sep 18, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@iliapolo
fix: revert "feat: configure SNS topics to receive stack events on th…
1366441 
…e Stack construct" (#54)

For the same reason we rolled back #33, this needs to be rolled back as well until we fix the release in this [PR](#53).

Reverts #29
@iliapolo iliapolo mentioned this pull request Sep 18, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@iliapolo
feat: configure SNS topics to receive stack events on the Stack const…
f4916ec 
…ruct (#58)

Reroll of #29 now that the release has been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@comcalvi @rix0rrr