Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dynamic require failure to runbook #1315

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Sep 22, 2023

This PR moves the "Errors Encountered in the Past" section from the operator-runbook to a new document named errors-encountered. An entry for Transliterator task failures caused by missing files has been added to the errors-encountered document which explains that the cause may be from a dynamic require being used in a dependency. A link to the errors-encountered doc has been added to the appendix section in the operator-runbook.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ that you're thinking to add documentation and explanation!

But, I'm going to rain on this a little nevertheless, and sorry in advance! 😉

You have to imagine the operator runbook being used by someone in a stressful situation: they've just gotten paged, or are trying to debug a system problem, and quicker is better.

Runbooks should be simple to parse, and have something of a error message -> steps to diagnose -> steps to fix pattern. (I know it might not be in a great state even right now, but let's try and keep the steps in a runbook actionable).

The runbook is not the place for a history lesson and background explanation. If you want, put that in another file and link to it. I wonder if we need this section at all. Is there ever a case where this information is useful under stress? What is the minimum bit of info that is necessary to help an operator when this occurs?

colifran and others added 3 commits September 25, 2023 09:35
Signed-off-by: Francis <colifran@amazon.com>
Signed-off-by: Francis <colifran@amazon.com>
@cdklabs-automation cdklabs-automation added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 8b03c5f Sep 25, 2023
10 checks passed
@cdklabs-automation cdklabs-automation deleted the colifran/dynamic-require-runbook branch September 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants