fix: Feed builder lambda times out #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update memory to 1024MB * Add failure alarm
* Adding section for new feed builder failure alarm * Fixing typos and linting
MrArnoldPalmer
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The feed builder lambda was timing out and consistently failing causing the atom feed to not be updated.
Solution
After investigation, it was determined the default memory, 128MB, was insufficient for the lambda to correctly execute. This PR increases the memory to 1024MB, a number verified by dev testing, and adding an alarm such that future issues will be flagged.
Investigation notes
Below you can see the metrics from the lambda function before and after increasing the memory allocation, approximately 21:45UTC.
Note that when the issue was resolved the invocations, throttles and events spike, then return to a low steady state. I believe this is due to the long backlog of work the lambda had to work through as it hasn't run correctly in ~seven months.
This fixes #1238.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license