fix: improve ingestion reprocessing flow #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truggeriaws
approved these changes
Feb 13, 2024
| @@ -481,22 +480,17 @@ class ReprocessIngestionWorkflow extends Construct { | |||
| .afterwards(); | |||
|
|
|||
| const process = new Map(this, 'Process Result', { | |||
| itemsPath: '$.response.Contents', | |||
| inputPath: `$.response.Contents[*][?(@.Key =~ /^.*${METADATA_KEY_SUFFIX}$/)]`, | |||
There was a problem hiding this comment.
nit: Putting this into a variable would give it slightly more context, especially since JSONPath is not very readable IMO.
const METADATA_KEY_JSON_PATH_FILTER = `?(@.Key =~ /^.*${METADATA_KEY_SUFFIX}$/)`;
...
inputPath: `$.response.Contents[*][${METADATA_KEY_JSON_PATH_FILTER}]`,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces part of the ingestion reprocess workflow's map to only operate on metadata.json files rather than looping through all objects.
The ingestion reprocess workflow has an inefficient state machine map to find metadata.json files. We can cut down on the number of state transitions by using a JSONPath regex filter instead.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license