fix: Updating SLA-Breached evaluation periods #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLargent42
approved these changes
Apr 22, 2024
adaviso
reviewed
Apr 22, 2024
| @@ -599,7 +599,7 @@ export class NpmJs implements IPackageSource { | |||
| `Runbook: ${RUNBOOK_URL}`, | |||
| ].join('\n'), | |||
| comparisonOperator: ComparisonOperator.GREATER_THAN_THRESHOLD, | |||
| evaluationPeriods: 2, | |||
| evaluationPeriods: 4, | |||
There was a problem hiding this comment.
In order to make a similar functional change, I would just have to update this parameter, correct? Everything else is just computer-updated or typo fixes?
There was a problem hiding this comment.
That's correct. There's lots of snapshot tests in the test suite - this was my attempt to update them; although, I think those changes were actually unnecessary.
adaviso
approved these changes
Apr 22, 2024
truggeriaws
force-pushed
the
followerAlarm
branch
from
0c7e2eb to
64a8e2d
Compare
Signed-off-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are observing that upon resolution of npmjs replica lag, the
SLA-Breachedalarm triggers during the period of time where the application consumes the updates from the backlog. The alarm is self resolving as there is no issue with the backend.Solution
Update the evaluation period from 2 (10 minutes) to 4 (20 minutes) to allow for the system to catch up before reporting an alarm.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license