Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(orchestration): tweak config for faster failures and less wasted performance #1419

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix(orchestration): tweak config for faster failures and less wasted performance #1419

merged 2 commits into from
Aug 30, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Aug 28, 2024 •
edited
Loading

  • reduce heartbeat time for faster failures (expected every 5min, send every 90s)
  • reduces transliteration task retries on timeout (missed heartbeat) to 3 and adds wait and backoff
  • reduce max time for transliteration task to 1hr (down from 2hrs)
  • remove ulimit config that is not required
  • reduce size of additional lambda functions by replacing typed CacheStrategy with strings, with removes aws-cdk-lib from bundling

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain changed the title fix(orchestration): tweak config for faster failures and less wasted … fix(orchestration): tweak config for faster failures and less wasted performance Aug 28, 2024
@mrgrain mrgrain force-pushed the mrgrain/tweaks branch 4 times, most recently from 5ab2234 to 5fe0cd2 Compare August 29, 2024 15:50
@mrgrain mrgrain marked this pull request as ready for review August 29, 2024 16:12
mrgrain
mrgrain commented Aug 29, 2024
View reviewed changes
src/caching.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is not part of the public API, so the change is fine.

@cdklabs-automation cdklabs-automation added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit b4aec14 Aug 30, 2024
6 checks passed
@cdklabs-automation cdklabs-automation deleted the mrgrain/tweaks branch August 30, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrgrain @rix0rrr @cdklabs-automation