fix: improve API reference URLs take 2 #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, but adding |
Signed-off-by: github-actions <github-actions@github.com>
This was referenced Jan 31, 2022
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2022
In #726, I missed that the `uploadFile` helper was automatically adding `text/markdown` to all files, including the JSON files that were added. Fixed this by inferring the correct content type. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #720 for original context.
Compared to the original PR, this adds the following fixes:
S3Objectarrays and only returning the keys instead. This is needed to prevent failures caused by the output being too large.TODO: update jsii-docgen version once cdklabs/jsii-docgen#571 is merged
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license