Skip to content

Commit

Permalink
chore: fix windows compat build silently failing (#1538)
Browse files Browse the repository at this point in the history
The Windows compat build has been silently failing for a while due to [the twine issue](aws/jsii#4554) in jsii-pacmak.

Fixing the build, by upgrading the pacmak version.

Fixing the silent failure by adding a meta job that we can add a branch protection for.
  • Loading branch information
mrgrain authored Aug 26, 2024
1 parent 14d6ebb commit 4f01fcd
Show file tree
Hide file tree
Showing 4 changed files with 1,161 additions and 483 deletions.
16 changes: 15 additions & 1 deletion .github/workflows/build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 21 additions & 1 deletion projenrc/rosetta.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class RosettaPeerDependency extends Component {
project.addDevDeps(constraint);
project.addPeerDeps(constraint);

project.github?.tryFindWorkflow('build')?.addJob('rosetta-compat', {
project.github?.tryFindWorkflow('build')?.addJob('rosetta-matrix', {
runsOn: ['${{ matrix.os }}'],
permissions: {},
env: {
Expand Down Expand Up @@ -84,6 +84,26 @@ export class RosettaPeerDependency extends Component {
run: `test $(npx ${JSII_ROSETTA} --version) = "\${{ matrix.rosetta }}"`,
}],
});
project.github?.tryFindWorkflow('build')?.addJob('rosetta-compat', {
// This is a simple "join target" to simplify branch protection rules.
env: { CI: 'true' },
name: 'Rosetta Compat Tests',
needs: ['rosetta-matrix'],
permissions: {},
runsOn: ['ubuntu-latest'],
if: 'always()',
steps: [
{
name: 'Tests result',
run: 'echo ${{needs.rosetta-matrix.result}}',
},
{
if: "${{ needs.rosetta-matrix.result != 'success' }}",
name: 'Set status based on matrix build',
run: 'exit 1',
},
],
});
}

private calculateVersionConstraint(versions: RosettaPeerDependencyOptions['supportedVersions']): string {
Expand Down
Loading

0 comments on commit 4f01fcd

Please sign in to comment.