revert: remove the addition of Dependabot security #343
+0
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiehan
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
[
|
[
|
[
|
team-tf-cdk
approved these changes
Dec 20, 2024
[
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: 508d0d9, a860e4a
I think I found a bug with the
repository_dependabot_security_updatesresource in the GitHub provider. When I initially created it just using the simple repository name as the example suggests, I got the error:Looking at this, what seems to be wrong is that it's using
team-tf-cdk/cdktf-cdk8sinstead ofcdktf/cdktf-cdk8s.team-tf-cdkis the owner of the GitHub access token, so that's probably where it's deriving that from.So then I tried to see if passing the full name of the repo might do the trick, but now it just fails with:
It's not clear how else to make it understand that it's dealing with a repo that belongs to an org, so like I said, I suspect this is a bug in the GitHub provider.
I might file an issue over there, but in the meantime, I'm just going to revert these commits and give up on this effort for now.