Update in attachment proccess #321

Muhammad1Nouman · 2019-12-19T13:16:34Z

Hi Greg,

#318 (comment) is working fine and is uploading all types of file correctly. However, the problem occurs when your tired to download the uploaded files (from trello board) specifically pdf, excel and document files etc. In addition when ones tries to view .pdf, .docx files will not be able to view it on trello board.

However, if the WebApiClient file method GetContent is modified like this

private static HttpContent GetContent(WebApiRestRequest request)
{
    if (request.File != null)
    {
	var formData = new MultipartFormDataContent();
	foreach (var parameter in request.Parameters)
	{
		var content = new StringContent(parameter.Value.ToString());
		formData.Add(content, $"\"{parameter.Key}\"");
	}
       var fileStream = File.Open(request.File, FileMode.Open);
       var fileInfo = new FileInfo(request.File);
       formData.Add(new StreamContent(fileStream), "\"file\"", string.Format("\"{0}\"", "as" + fileInfo.Extension));
       formData.Add(new StringContent("mimeType"), "image/png");
       formData.Add(new StringContent("name"), request.FileName);
       TrelloConfiguration.Log.Debug($"\tContent: {formData}");
       return formData;
  }

 if (request.Body == null) return null;

     var body = TrelloConfiguration.Serializer.Serialize(request.Body);
     var jsonContent = new StringContent(body);
     jsonContent.Headers.ContentType = new MediaTypeHeaderValue("application/json");
     TrelloConfiguration.Log.Debug($"\tContent: {body}");
     return jsonContent;
}

This code is still be able to upload all types of files, and the user will also be able to download file in original format, and can view it on the trello board as well.

…rello

Manatee.Trello/Rest/WebApiClient.cs

gregsdennis · 2020-01-29T05:16:46Z

Manatee.Trello/Contracts/IBoardBackgroundCollection.cs

+        /// <param name="filePath">The path of the file to attach.</param>
+        /// <param name="ct">(Optional) A cancellation token for async processing.</param>
+        /// <returns>The newly created <see cref="IBoardBackground"/>.</returns>
+        Task<IBoardBackground> Add(string filePath, CancellationToken ct = default);


Instead of changing this, can you just add the new method, please? This will allow us to avoid a breaking change.

Alright, its seems to be a great idea

gregsdennis · 2020-01-29T05:17:15Z

Manatee.Trello/Rest/RestFile.cs

 		/// </summary>
-		public byte[] ContentBytes { get; set; }
+		public string FilePath { get; set; }


Similarly here: just add the property.

gregsdennis · 2020-01-29T05:18:02Z

Manatee.Trello/Rest/WebApiClient.cs


-				return formData;
+                var fileStream = File.Open(request.File, FileMode.Open);


Here you will need to check whether raw bytes have been uploaded or just a filename; then act appropriately.

gregsdennis

I think I'll move forward with this, but I don't want to lose existing functionality. Just a few suggestions on how to add this without creating breaking changes.

gregsdennis · 2020-01-29T20:42:47Z

Manatee.Trello/Rest/WebApiClient.cs

+                var fileStream = File.Open(request.File, FileMode.Open);
+                var fileInfo = new FileInfo(request.File);
+                formData.Add(new StreamContent(fileStream), "\"file\"", string.Format("\"{0}\"", "as" + fileInfo.Extension));
+                formData.Add(new StringContent("mimeType"), "image/png");


I'd like to have some simple functionality that attempts to infer the mime type from the file extension. Not looking for an extensive list; more like a "top 10."

gregsdennis

Some comments. Also tabs, not spaces, please.

gregsdennis · 2020-01-30T19:31:05Z

Manatee.Trello.IntegrationTests/ClientTestsOfTheNew.cs

@@ -21,8 +21,9 @@ public async Task Issue205_CopyCardWithAttachment()
 			var list = board.Lists.Last();
 			var cards = list.Cards;
 			var sourceCard = await TestEnvironment.Current.BuildCard();
-			var jpeg = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "Files/smallest-jpeg.jpg");
-			await sourceCard.Attachments.Add(File.ReadAllBytes(jpeg), "smallest-jpeg.jpg");
+			var pdf = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "Files/smallest-jpeg.jpg");


I'd prefer not to change the client tests since they're associated with specific issues. Can you create a new test that uses the new code path, please?

Manatee.Trello/Contracts/IAttachmentCollection.cs

Manatee.Trello/Manatee.Trello.csproj

gregsdennis · 2020-01-30T19:35:40Z

Manatee.Trello/Contracts/IMemberStickerCollection.cs

+        /// <param name="name">A name for the sticker.</param>
+        /// <param name="ct">(Optional) A cancellation token for async processing.</param>
+        /// <returns>The <see cref="ISticker"/> generated by Trello.</returns>
+        Task<ISticker> Add(string filePath, string name, CancellationToken ct = default);


Please add an override.

Manatee.Trello/Rest/WebApiClient.cs

gregsdennis · 2020-01-30T19:39:36Z

Manatee.Trello/Rest/WebApiRequestProvider.cs

@@ -24,7 +24,7 @@ public IRestRequest Create(string endpoint, IDictionary<string, object> paramete
 					if (parameter.Key == RestFile.ParameterKey)
 					{
 						var rf = (RestFile)parameter.Value;
-						request.AddFile(parameter.Key, rf.ContentBytes, rf.FileName);
+						request.AddFile(parameter.Key, rf.FilePath, rf.FileName);


We need to check which attachment method we're using here. I don't want to completely replace the existing bytes method.

gregsdennis · 2020-01-30T19:40:24Z

Manatee.Trello/Rest/WebApiClient.cs

+                    var fileStream = File.Open(request.FilePath, FileMode.Open);
+                    var fileInfo = new FileInfo(request.FilePath);
+                    formData.Add(new StreamContent(fileStream), "\"file\"", string.Format("\"{0}\"", "as" + fileInfo.Extension));
+                    formData.Add(new StringContent("mimeType"), "image/png");


I'd still like to have some basic mime type checking rather than always assuming png.

Muhammad1Nouman · 2020-02-01T06:56:52Z

Manatee.Trello/Rest/WebApiClient.cs

+                                if (request.FilePath != null)
+                                {


Here I am verifying, whether the file is uploaded or byte array.

Muhammad1Nouman · 2020-02-01T06:57:09Z

Manatee.Trello/Rest/WebApiRequestProvider.cs

+
+                                                if (rf.FilePath != null)
+                                                {


Same reason as above

Muhammad1Nouman · 2020-02-01T06:59:51Z

Manatee.Trello/Rest/WebApiRestRequest.cs

+                public void AddFile(string key, string filePath, string fileName)
+                {
+                    FilePath = filePath;
+                    FileName = fileName;
+                }


Here, overloading the of AddFile method for assigning file location as well

gregsdennis · 2020-02-02T19:17:16Z

I don't know what your editor is doing, but it keeps putting spaces in instead of tabs. The alignment is all off.

Also, for the build, the card attachment test is failing. I'd like to also see a test that uses your method to attach a file. The BasicData test has been resolved on the current master branch, so don't worry about that. I'll rebase the target branch so that it's fixed.

gregsdennis · 2020-02-04T01:35:33Z

Trello has reported an error with the request: {"message":"Must provide either url or file","error":"VALIDATOR_INVALID_VALUE"}

Muhammad1Nouman added 10 commits December 19, 2019 17:56

Update in attachment proccess

8304c3b

change in attachment test cases

8849d70

change in attachment test cases

85869d2

Delete Program.cs

6cb873d

Delete trelloTest.csproj

de63388

Delete util.cs

1d96056

A small change in test cases

7d015a8

some change in attachment test case

677802f

Merge branch 'master' of https://github.com/Muhammad1Nouman/Manatee.T…

ecb636c

…rello

change in BoardBackgroundCollection file

7d674ba

gregsdennis changed the base branch from master to bug/318-file-uploads December 19, 2019 17:45

gregsdennis reviewed Jan 14, 2020

View reviewed changes

Manatee.Trello/Rest/WebApiClient.cs Outdated Show resolved Hide resolved

gregsdennis reviewed Jan 14, 2020

View reviewed changes

Manatee.Trello/Rest/WebApiClient.cs Outdated Show resolved Hide resolved

gregsdennis reviewed Jan 29, 2020

View reviewed changes

gregsdennis requested changes Jan 29, 2020

View reviewed changes

gregsdennis reviewed Jan 29, 2020

View reviewed changes

Requested Changes

302af22

gregsdennis requested changes Jan 30, 2020

View reviewed changes

Muhammad1Nouman added 3 commits January 31, 2020 02:48

Requested Changes

1bd2719

Requested Changes

60490be

Fix Tab spaces

91dfa79

Muhammad1Nouman commented Feb 1, 2020

View reviewed changes

Manatee.Trello/Rest/WebApiRequestProvider.cs

Comment on lines +27 to +29

if (rf.FilePath != null)

{

Copy link

Author

Muhammad1Nouman Feb 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason as above

Muhammad1Nouman commented Feb 1, 2020

View reviewed changes

Tab issues

24885f4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update in attachment proccess #321

Update in attachment proccess #321

Muhammad1Nouman commented Dec 19, 2019

gregsdennis Jan 29, 2020

Muhammad1Nouman Jan 30, 2020

gregsdennis Jan 29, 2020

gregsdennis Jan 29, 2020

gregsdennis left a comment

gregsdennis Jan 29, 2020

gregsdennis left a comment

gregsdennis Jan 30, 2020

Muhammad1Nouman Jan 30, 2020

gregsdennis Jan 30, 2020

gregsdennis Jan 30, 2020

gregsdennis Jan 30, 2020

Muhammad1Nouman Feb 1, 2020

Muhammad1Nouman Feb 1, 2020

Muhammad1Nouman Feb 1, 2020

gregsdennis commented Feb 2, 2020

gregsdennis commented Feb 4, 2020


		return formData;
		var fileStream = File.Open(request.File, FileMode.Open);

Update in attachment proccess #321

Are you sure you want to change the base?

Update in attachment proccess #321

Conversation

Muhammad1Nouman commented Dec 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gregsdennis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gregsdennis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gregsdennis commented Feb 2, 2020

gregsdennis commented Feb 4, 2020