-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to sha384/512 on SRI hash calculation #11123
Comments
Bringing @drewfreyling's comment from #13384: I'm in favour of just offering up the SHA-512 values since it is:
If at some point we get fragmented browser support than I think providing multiple hashes makes sense. |
@PeterDaveHello @MattIPv4 |
cc @zackbloom @xtuc |
We should keep this open as we are still looking at implementing this. |
Feel free to open a new issue for it(or maybe just use the opened pull request for discussion), as I was removed from the organization without any discussion and respect, just like some other members(I know it's not by you and you're not the one who's in charge for that), I'm now closing ancient issues I'm not working on so that I don't need to receive unnecessary notifications, thanks. |
Noting this down: the current SRI generation happens in https://github.com/cdnjs/tools/blob/master/packages/packages.go#L86 & https://github.com/cdnjs/tools/blob/master/openssl/sri.go |
I have opened a PR: cdnjs/tools#46 |
Thanks for your PR @klausenbusk! It already lgtm but I want to make sure which SHA-384/512 we should be using |
Issues:
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: