Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

Search highlight enhancement #148

Open
PeterDaveHello opened this issue Dec 20, 2016 · 5 comments
Open

Search highlight enhancement #148

PeterDaveHello opened this issue Dec 20, 2016 · 5 comments

Comments

@PeterDaveHello
Copy link
Contributor

search pattern:

  • smalot bootstrap-datetimepicker
  • smalot/bootstrap-datetimepicker

The repository part, only the author string will have highlight, only smalot\/bootstrap-datetimepicker can highlight them together (but not slash)

@qas612820704
Copy link
Contributor

If we submit smalot\/bootstrap-datetimepicker to algoria,

it considers that \/ is kind of typo not escape character /.

The result will be the same if we change \/ to 1/ or ~/.

So, do we need to add function that if we submit author/repo it will search by github?

@PeterDaveHello
Copy link
Contributor Author

IMO it's not about what do we submit to algolia, but how we highlight them in https://github.com/cdnjs/new-website/blob/master/public/js/main.js, agree?

@MattIPv4
Copy link
Member

I believe this is still an issue that should be looked at, so going to keep this open.

@MattIPv4 MattIPv4 reopened this Feb 23, 2020
@PeterDaveHello
Copy link
Contributor Author

Feel free to open a new issue for it, as I was removed from the organization without any discussion and respect, just like some other members(I know it's not by you and you're not the one who's in charge for that), I'm now closing ancient issues I'm not working on so that I don't need to receive unnecessary notifications, thanks.

@MattIPv4
Copy link
Member

As mentioned here and here, please use the unsubscribe button in this issue if you no longer wish to receive notifications for it. However, please leave this issue open as it is still needed.

@MattIPv4 MattIPv4 reopened this Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants