Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layui w/ git auto-update #1700

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Update layui w/ git auto-update #1700

merged 3 commits into from
Dec 6, 2023

Conversation

sentsim
Copy link
Contributor

@sentsim sentsim commented Nov 20, 2023

The current files matching rule does not include layui.css.map (https://cdnjs.com/libraries/layui/2.9.0-beta.1).
All files in the dist directory should be included.
ref: https://unpkg.com/browse/layui@2.9.0-beta.1/dist/

packages/l/layui.json Outdated Show resolved Hide resolved
Co-authored-by: Matt Cowley <me@mattcowley.co.uk>
packages/l/layui.json Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 merged commit fce7e4a into cdnjs:master Dec 6, 2023
1 check passed
@sentsim
Copy link
Contributor Author

sentsim commented Dec 6, 2023

@MattIPv4 Thank you for your suggestion and quick handling of the PR.
BTW, Can I make the following modifications? Because it looks more concise.

"files": [
-   "*.js?(.map)",
-   "css/**/*.css?(.map)",
-   "font/*.@(eot|ttf|svg|woff|woff2)"
+   "**/*.@(js|css|map|eot|ttf|svg|woff|woff2)"
]

@MattIPv4
Copy link
Member

MattIPv4 commented Dec 6, 2023

I don't really see any reason to make such a change?

@sentsim
Copy link
Contributor Author

sentsim commented Dec 6, 2023

Okay, Then let's keep it as is. Thanks again. 👍

@sentsim sentsim deleted the update-layui-w-git-autoupdate branch December 6, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants