Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about extensions needing to be OSS #113

Merged
merged 3 commits into from
Mar 22, 2019
Merged

Add note about extensions needing to be OSS #113

merged 3 commits into from
Mar 22, 2019

Conversation

hbjydev
Copy link

@hbjydev hbjydev commented Mar 8, 2019

Describe in detail the problem you had and how this PR fixes it

Some people might think this is a catch-all for every VS Code need in the browser, I'm just informing them that only the open source extensions can be used (i.e. no VS Live Share, etc.)

Is there an open issue you can link to?

Nope.

@bpmct
Copy link
Member

bpmct commented Mar 8, 2019

Will you still be able to upload closed-source extensions via a VSIX file (as soon as that gets working #92)? Or are there other problems associated with that?

@NGTmeaty
Copy link
Contributor

NGTmeaty commented Mar 8, 2019

Closed-source extensions with VSIX will work after #92 gets fixed. I'm going request a slight change here.

README.md Outdated Show resolved Hide resolved
@hbjydev
Copy link
Author

hbjydev commented Mar 8, 2019

@NGTmeaty Done, I agree, it looks better

Copy link
Contributor

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very very important to make clear that we use the official Marketplace

README.md Outdated
@@ -62,6 +62,10 @@ How to [secure your setup](/doc/security/ssl.md).
- Electron and ChromeOS applications to bridge the gap between local<->remote.
- Run VS Code unit tests against our builds to ensure features work as expected.

### Notes

- At the moment we can't use the official VSCode Marketplace. Coder has created a collection of extensions that are open-source. While you can't directly download extensions from the official VSCode Marketplace, you can upload them to be installed in code-server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to phrase this as:
We've created a custom extension marketplace focused around open-sourced extensions.
I'd like to convey that we don't just package a few additional exts, and it is a full marketplace that will be improved.

@hbjydev
Copy link
Author

hbjydev commented Mar 12, 2019

Alright. I've edited it, and kept in the little bit on the end about being able to if you have the VSIX file

@code-asher
Copy link
Member

code-asher commented Mar 13, 2019

I'm thinking we might want to wait until #92 is resolved since installing extensions manually won't work until that issue is resolved (or we can leave out the bit about vsix and add it back once the fix is in).

@NGTmeaty
Copy link
Contributor

VSIX has a active PR 🎉 #245

@kylecarbs
Copy link
Member

Will merge once #245 is in!

@NGTmeaty
Copy link
Contributor

#245 is in. Merge?

@code-asher code-asher merged commit 80c1987 into coder:master Mar 22, 2019
@hbjydev hbjydev deleted the patch-1 branch March 22, 2019 21:17
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* Add note about extensions needing to be OSS

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants