-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about extensions needing to be OSS #113
Conversation
Will you still be able to upload closed-source extensions via a VSIX file (as soon as that gets working #92)? Or are there other problems associated with that? |
Closed-source extensions with VSIX will work after #92 gets fixed. I'm going request a slight change here. |
@NGTmeaty Done, I agree, it looks better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very very important to make clear that we use the official Marketplace
README.md
Outdated
@@ -62,6 +62,10 @@ How to [secure your setup](/doc/security/ssl.md). | |||
- Electron and ChromeOS applications to bridge the gap between local<->remote. | |||
- Run VS Code unit tests against our builds to ensure features work as expected. | |||
|
|||
### Notes | |||
|
|||
- At the moment we can't use the official VSCode Marketplace. Coder has created a collection of extensions that are open-source. While you can't directly download extensions from the official VSCode Marketplace, you can upload them to be installed in code-server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to phrase this as:
We've created a custom extension marketplace focused around open-sourced extensions.
I'd like to convey that we don't just package a few additional exts, and it is a full marketplace that will be improved.
Alright. I've edited it, and kept in the little bit on the end about being able to if you have the VSIX file |
I'm thinking we might want to wait until #92 is resolved since installing extensions manually won't work until that issue is resolved (or we can leave out the bit about |
VSIX has a active PR 🎉 #245 |
Will merge once #245 is in! |
#245 is in. Merge? |
* Add note about extensions needing to be OSS * Update README.md * Update README.md
Describe in detail the problem you had and how this PR fixes it
Some people might think this is a catch-all for every VS Code need in the browser, I'm just informing them that only the open source extensions can be used (i.e. no VS Live Share, etc.)
Is there an open issue you can link to?
Nope.