Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect archive type of extension to decompress #92

Closed
kylecarbs opened this issue Mar 7, 2019 · 2 comments · Fixed by #245
Closed

Detect archive type of extension to decompress #92

kylecarbs opened this issue Mar 7, 2019 · 2 comments · Fixed by #245
Assignees
Labels
enhancement Some improvement that isn't a feature

Comments

@kylecarbs
Copy link
Member

We've filled the client zip implementation with tar so we can eventually load extensions on the client. Installing from a VSIX no longer works because the standard format is a zip.

We should detect the archive type then use the appropriate fill.

@RiFi2k
Copy link

RiFi2k commented Mar 15, 2019

Not sure what the limitations are here but is using the CLI an option?

https://code.visualstudio.com/docs/editor/command-line

I was able to mess around and figure out their public API for the extension gallery.

curl -X POST \
  'https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery?api-version=5.1-preview.1' \
  -H 'Content-Type: application/json' \
  -H 'api-version: 5.1-preview.1' \
  -H 'cache-control: no-cache' \
  -d '{
    "assetTypes": [
        "Microsoft.VisualStudio.Services.Icons.Default",
        "Microsoft.VisualStudio.Services.Icons.Branding",
        "Microsoft.VisualStudio.Services.Icons.Small"
    ],
    "filters": [
        {
            "criteria": [
                {
                    "filterType": 8,
                    "value": "Microsoft.VisualStudio.Code"
                },
                {
                    "filterType": 10,
                    "value": "php"
                },
                {
                    "filterType": 12,
                    "value": "37888"
                }
            ],
            "direction": 2,
            "pageSize": 54,
            "pageNumber": 1,
            "sortBy": 0,
            "sortOrder": 0,
            "pagingToken": null
        }
    ],
    "flags": 870
}'

@foresthoffman
Copy link
Contributor

Howdy @RiFi2k, this isn't related to the current issue, but thank you for the suggestion. The reason we're not using the official VS Code Marketplace is because it is a restriction in their TOS. See the following comment from one of our CTO's: #30 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants