Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create license page #482

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Create license page #482

wants to merge 7 commits into from

Conversation

isaacvetter
Copy link
Member

Link from footer, intended to deprecrate PR #480

Copy link
Member

@jmandel jmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the content on the license page -- thanks for these updates!

I still think it's too hard to find, with a small black icon on a small black strip at the very bottom of the page. Even the main FHIR spec includes a link to the license front and center of the home page:

image

and has (slightly) better contrast on the link, and doesn't bury it so far below a think black footer:
image

My preference would be to keep a menu item like "License and Logo" in the nav bar, for discoverability. (I'm not just saying this because I want to push legal language on everyone; I worry taht the tiny link at the bottom will be actively hard to find for people who are looking.)

image

mkdocs.yml Outdated Show resolved Hide resolved
@isaacvetter
Copy link
Member Author

@jmandel - what's needed to close or move this issue forward?

Co-authored-by: Josh Mandel <jmandel@alum.mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants