This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Handling the reject of getRandomBytes for both iOS and Android.
#524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obrien-j
reviewed
Jul 8, 2020
There was a problem hiding this comment.
Looks good from my end.
Minor nit on the
} Catch (error) pattern, vs catch (exception), but that may be a common pattern in JS/React land, so not the end of the world.
As long as console.error tosses the stack trace, (assuming we want it), no objections.
I'll leave final approval to the team.
|
@obrien-j - In the rest of the *ts code, |
timarney
approved these changes
Jul 8, 2020
henrytao-me
reviewed
Jul 13, 2020
| val bytes = SecureRandom().generateSeed(size) | ||
| val base64Encoded = Base64.encodeToString(bytes, Base64.DEFAULT) | ||
| promise.resolve(base64Encoded) | ||
| try { |
There was a problem hiding this comment.
There is no need to try / catch here because .launch extension already handle exception.
Maybe next time, please ping me to PR for review whenever we change native code as I would like to bring it over to original repo too. 🙇
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both of the cases where getRandomBytes is called, if an error occurs, it will be logged so we know it happened, and thrown again and caught by the error handlers of FormView and ConsentView.