Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Typography and spacing #532

Merged
merged 14 commits into from
Jul 8, 2020
Merged

Typography and spacing #532

merged 14 commits into from
Jul 8, 2020

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Jul 8, 2020

This PR brings a lot of small tweaks in terms of typography, spacing, styles, colors, layout.

General

  • Default type size is 18 points across the app. We still have a smallText variant at 16
  • Added a medium title size for the settings page. 23 points
  • Large title size is 27 also 23 after all
  • Changes were made in components to assign proper styles to menu items
  • removed unnecessary Box nesting in ButtonSingleLine
  • lastItem on Menu Item components can be undefined. Cleaner code.
  • removed unnecessary Box nesting in StatusHeaderView
  • Tweaked selection menus to display rounded corners properly
  • Link color, success green colors were changed to match figma. And also meet contrast requirements
  • Added info-100 color for buttons across the app
  • reduced icon size from 150 to 120

Onboarding

  • Horizontal spacing on onboarding set to m
  • bulletX and BulletCheckmark spacing
  • rounded bulletX

Settings pages with content

  • Title moved from toolbar to content area. Checked with talkback. We still have the correct accessibilityRole of a header

@timarney timarney marked this pull request as ready for review July 8, 2020 15:58
@timarney timarney requested a review from a team as a code owner July 8, 2020 15:58
@amazingphilippe amazingphilippe changed the title Typography spacing Typography and spacing Jul 8, 2020
Copy link
Collaborator

@smcmurtry smcmurtry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that a couple of the buttons have text colour issues:
Screen Shot 2020-07-08 at 10 37 01 AM
Similar issue on the diagnosed/upload screen.

@amazingphilippe
Copy link
Contributor Author

Noticed that a couple of the buttons have text colour issues:
Similar issue on the diagnosed/upload screen.

Fixed in 11a1bc7

@timarney
Copy link
Member

timarney commented Jul 8, 2020

Pre 11a1bc7

Noting this for tracking:

@timarney
Copy link
Member

timarney commented Jul 8, 2020

Regression - Android

Updated to use single line button.

Copy link
Collaborator

@smcmurtry smcmurtry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for addressing the button text colour issue. Next time could you break your changes up into smaller PRs? 😜

@timarney
Copy link
Member

timarney commented Jul 8, 2020

Smaller PRs

i.e.
PRs

  • Button updates
  • Text updates
  • Section updates

Makes it easier to review + to get the updates in.

https://www.netlify.com/blog/2020/03/31/how-to-scope-down-prs/

@timarney timarney merged commit 72bd042 into master Jul 8, 2020
@timarney timarney deleted the typography-spacing branch July 8, 2020 21:41
@amazingphilippe
Copy link
Contributor Author

Definitely a bad habit of mine. Will do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants