This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…typography-spacing
…typography-spacing
smcmurtry
suggested changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 11a1bc7 |
Pre 11a1bc7 |
…typography-spacing
timarney
approved these changes
Jul 8, 2020
smcmurtry
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for addressing the button text colour issue. Next time could you break your changes up into smaller PRs? 😜
Smaller PRs i.e.
Makes it easier to review + to get the updates in. https://www.netlify.com/blog/2020/03/31/how-to-scope-down-prs/ |
Definitely a bad habit of mine. Will do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a lot of small tweaks in terms of typography, spacing, styles, colors, layout.
General
smallText
variant at 1627also 23 after alllastItem
on Menu Item components can be undefined. Cleaner code.Onboarding
m
Settings pages with content