Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fix notification permission is out of synced #538

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Fix notification permission is out of synced #538

merged 1 commit into from
Jul 8, 2020

Conversation

henrytao-me
Copy link
Contributor

This PR fixes notification permission is out of synced with device Settings

Ref #489

How to test?

  • Change notification permission (On / Off) in device Settings.
  • Verify that the app displays permission accordingly.

@henrytao-me henrytao-me requested a review from a team as a code owner July 8, 2020 17:12
smcmurtry
smcmurtry approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@smcmurtry smcmurtry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really well 👍

@henrytao-me henrytao-me merged commit a55794c into master Jul 8, 2020
@henrytao-me henrytao-me deleted the issue/489/push-notification branch July 8, 2020 22:19
@henrytao-me henrytao-me mentioned this pull request Jul 13, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@smcmurtry smcmurtry smcmurtry approved these changes

Assignees
No one assigned
Labels
pushed upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrytao-me @smcmurtry