This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Improve detect exposure flow #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrytao-me
commented
Jul 8, 2020
| @@ -105,23 +102,15 @@ class ExposureNotificationModule(context: ReactApplicationContext) : ReactContex | |||
|
|
|||
| exposureNotificationClient.provideDiagnosisKeys(files, exposureConfiguration, token).await() | |||
|
|
|||
| // Clean up files after feeding to the framework | |||
| files.forEach { it.cleanup() } | |||
There was a problem hiding this comment.
We can clean up the file as soon as we feed them into the framework.
timarney
approved these changes
Jul 8, 2020
|
A last follow up PR is still needed when Google update framework to return NOT_FOUND. Then, we can add lastCheckPeriod back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using timeout can introduce race condition. This PR change the implementation on Android by:
Not persisting lastCheckPeriodfor Android only. So that we won't miss any cases.Follow up of #453