This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Attempt to fix push notification #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrytao-me
commented
Jul 9, 2020
| @@ -31,7 +31,6 @@ BackgroundScheduler.registerAndroidHeadlessPeriodicTask(async () => { | |||
| SecureStorage, | |||
| ExposureNotification, | |||
| ); | |||
| await exposureNotificationService.init(); | |||
There was a problem hiding this comment.
This is moved to updateExposureStatusInBackground
henrytao-me
commented
Jul 9, 2020
| await this.updateExposureStatus(); | ||
| const currentStatus = this.exposureStatus.get(); | ||
| if (lastStatus.type === 'monitoring' && currentStatus.type === 'exposed') { | ||
| if (currentStatus.type === 'exposed' && !currentStatus.notificationSent) { |
There was a problem hiding this comment.
Change logic of showing notification. This making sure that we show exposed notification once.
henrytao-me
commented
Jul 9, 2020
timarney
approved these changes
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix push notification.
What could when wrong on master?
Initial state is incorrect:
Since we start persisting exposure status, we split
startintostartandinit. Because the initial state is retrieved from local storage, it is async. So, if the app is running in background (through background job), master just callupdateExposureStatusInBackgroundwithout calling init. Based on this assumption,On Android: ✅
We call
initbefore callingupdateExposureStatusInBackgroundwhich means Android should receive notification. If there is no notification, it could be different issue.On iOS: ❌
We don't call
initinbackgroundScheduler.registerPeriodicTaskwhich means in some race condition, iOS won't have correct initial state.Logic to show notification:
Also the logic for showing exposed notification is quite fragile to break https://github.com/cds-snc/covid-shield-mobile/blob/master/src/services/ExposureNotificationService/ExposureNotificationService.ts#L151. Essentially, we want to send exposure notification to user only once but the way we are doing it is checking the status from
monitoringtoexposed.This will break when: If user finishes onboarding and minimize the app, the app still runs in but without
updateExposureStatusInBackground. It means if the status is changed toexposed, the next timeupdateExposureStatusInBackgroundis run, it won't show notification. In this case, user doesn't know that the app is set to exposed already.Ref #570