Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Fixed buttons on Android not showing Ripple effect #663

Merged
merged 7 commits into from
Jul 13, 2020
Merged

Fixed buttons on Android not showing Ripple effect #663

merged 7 commits into from
Jul 13, 2020

Conversation

nickmly
Copy link
Contributor

@nickmly nickmly commented Jul 13, 2020 •
edited
Loading

Fixes #655

  • Switched from custom Ripple solution to use RectButton component from react-native-gesture-handler for performance and accessibility.

@nickmly nickmly requested a review from a team as a code owner July 13, 2020 17:10
amazingphilippe
amazingphilippe reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@amazingphilippe amazingphilippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting on border radius in general!

src/components/Button.tsx Outdated Show resolved Hide resolved
src/components/ButtonMultiline.tsx Outdated Show resolved Hide resolved
@timarney
Copy link
Member

timarney commented Jul 13, 2020 •
edited
Loading

@amazingphilippe - any further comments before this is merged?

henrytao-me
henrytao-me approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@henrytao-me henrytao-me left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I haven't tested it. I will cherry-pick to original repo tonight. Thanks for doing this. 🙇

@timarney
Copy link
Member

I tested it works well :)

@timarney
Copy link
Member

Will merge and we can adjust in another PR as need be.

@timarney timarney merged commit a1c218c into master Jul 13, 2020
@timarney timarney deleted the issue/655/button-ripple branch July 13, 2020 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amazingphilippe amazingphilippe amazingphilippe left review comments

@henrytao-me henrytao-me henrytao-me approved these changes

@timarney timarney timarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No visual changes available on focus state/pressed for some buttons on Android
5 participants
@nickmly @timarney @amazingphilippe @henrytao-me @NickMalloryODS