Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

splash screen with logo #726

Merged
merged 3 commits into from
Jul 16, 2020
Merged

splash screen with logo #726

merged 3 commits into from
Jul 16, 2020

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Jul 16, 2020 •
edited
Loading

Closes #653

Updated splash screen to display logo

@amazingphilippe amazingphilippe mentioned this pull request Jul 16, 2020
Closed
@mtropper
Copy link
Contributor

@amazingphilippe Replace
app:srcCompat="@drawable/ic_icon_wordmark"
with:
android:src="@drawable/ic_icon_wordmark"

@amazingphilippe
Copy link
Contributor Author

Awesome! Thank you!

@amazingphilippe amazingphilippe marked this pull request as ready for review July 16, 2020 19:58
@amazingphilippe amazingphilippe requested a review from a team as a code owner July 16, 2020 19:58
@amazingphilippe amazingphilippe changed the title Help: splash screen with logo splash screen with logo Jul 16, 2020
@JuliannaR JuliannaR self-requested a review July 16, 2020 22:23
JuliannaR
JuliannaR approved these changes Jul 16, 2020
View reviewed changes
Copy link

@JuliannaR JuliannaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@timarney timarney merged commit 72168f3 into master Jul 16, 2020
@timarney timarney deleted the issue/653/splash-screen-with-logo branch July 16, 2020 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JuliannaR JuliannaR JuliannaR approved these changes

@timarney timarney timarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New splash screen
4 participants
@amazingphilippe @mtropper @timarney @JuliannaR