This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Use TextInput instead of CodeInput in FormView #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrytao-me
commented
Jul 16, 2020
henrytao-me
commented
Jul 16, 2020
|
|
||
| <item name="colorPrimary">#2B4380</item> | ||
| <item name="colorPrimaryDark">#26374A</item> | ||
| <item name="colorControlActivated">#26374A</item> |
There was a problem hiding this comment.
This will help with the cursor color for Android.
There was a problem hiding this comment.
|
Looks good! Can we align the input text to the left? |
| padding="s" | ||
| maxLength={8} | ||
| fontSize={26} | ||
| borderWidth={0} |
There was a problem hiding this comment.
I was playing around and if I can suggest these attributes I think it would be cool!
autoCapitalize="characters"
fontFamily="Menlo"
letterSpacing={5}
|
Tested on iOS device - I'm seeing white text on a white background. |
timarney
approved these changes
Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #727