Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

fix for cropped symbols on home screen #753

Merged
merged 2 commits into from
Jul 17, 2020
Merged

fix for cropped symbols on home screen #753

merged 2 commits into from
Jul 17, 2020

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Jul 17, 2020 •
edited
Loading

  • Symbols are not being cropped on the homescreen anymore
  • Used a combination of SafeAreaView and ScrollView to prevent anything from being cut-off by notches, while not creating excess padding on other devices

On notched devices:
Capture d’écran, le 2020-07-17 à 11 23 37
Capture d’écran, le 2020-07-17 à 11 23 40

On other devices:
Capture d’écran, le 2020-07-17 à 11 24 26
Capture d’écran, le 2020-07-17 à 11 24 33

@amazingphilippe amazingphilippe requested a review from a team as a code owner July 17, 2020 15:26
@timarney timarney merged commit ccf3fcf into master Jul 17, 2020
@timarney timarney deleted the landscape-padding branch October 9, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timarney timarney timarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amazingphilippe @timarney