Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

A11y focus issues #766

Merged
merged 6 commits into from
Jul 17, 2020
Merged

A11y focus issues #766

merged 6 commits into from
Jul 17, 2020

Conversation

nickmly
Copy link
Contributor

@nickmly nickmly commented Jul 17, 2020

Fixes #734 and #732

These issues relate to the navigation not handling the useLayoutEffect hook when the screen changes focus. Fixes below allow for calling a function to manually focus on elements after the screen has received focus in certain scenarios where needed. Tested on Android with TalkBack.

  • Added focusOnElement function to /src/shared/useAccessibilityAutoFocus.ts to allow focus on elements from anywhere in code
  • useAccessibilityAutoFocus now returns an array containing: [Manual focus ref , Auto focus ref]

@nickmly nickmly linked an issue Jul 17, 2020 that may be closed by this pull request
@nickmly nickmly marked this pull request as ready for review July 17, 2020 20:26
@nickmly nickmly requested a review from a team as a code owner July 17, 2020 20:26
@timarney timarney merged commit fe12522 into master Jul 17, 2020
@timarney timarney deleted the issue/734/focus branch July 17, 2020 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants