This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Remove the "0 days left" text that is shown after the 14 day upload cycle is finished #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their 14 day upload cycle
|
@smcmurtry let's review this today. |
timarney
approved these changes
Jul 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #802. This fix was arrived at after discussion w/ @katewilhelm.
Homescreen shown after the user uploads for the last time:
Before (Ontario):
After (Ontario):
Menu shown after the user uploads for the last time:
Before:
After:
Details on local testing
To test this locally, I modified the
getCurrentDatefn. And I commented out the server requestreportDiagnosisKeyson @henrytao-me's advice since it was giving me a 400 error. Here is what I observed before making this PR:Today: July 20th
-> I upload a one time diagnosis key and agree to share my "random codes"
homescreen: "Thank you" screen, "For the next 13 days you'll get a daily notification..."
menu: 13 days left
-> I change the source code and fast forward to July 31st
homescreen: "Upload random codes" screen
menu: 2 days left
-> I upload my random codes
homescreen: "Thank you" screen, "For the next 2 days..."
menu: 2 days left
-> I fast forward to Aug 1st
homescreen: "Upload random codes" screen
menu: 1 day left
-> I upload my random codes
homescreen: "Thank you" screen, "Tomorrow you'll get your last notification..."
menu: 1 day left
-> I fast forward to Aug 2nd
homescreen: "Upload random codes" screen
menu: 0 days left
-> I upload my random codes
homescreen: "Thank you" screen, "For the next 0 days you'll get a daily notification..."
menu: 0 days left
-> I fast forward to Aug 3
homescreen: I am back to monitoring: "No exposure detected" screen
menu: "Diagnosed w/ Covid? enter your one-time key..."