Fixes blank tutorial pages when in landscape

[joshpc]

What this does

This fixes an issue where tutorial pages would render as blank when presented in landscape mode.

Why? How?

The Carousel's rendering optimization (of not rendering off-screen elements) was not rendering the first element when the Carousel itself was completely offscreen. A re-render was properly triggering it to be visible, but the effect is a little jarring (it's a screen flicker) or broken (completely blank in landscape mode as no re-render is triggered.)

By disabling removeClippedSubviews this forces the views to be rendered and visible. A side-effect of this is that the views that are off-screen are rendered and on the stack, but given the small quantity of views, this may be an acceptable change.

An alternative fix would be to use Carousel's triggerRenderingHack-- see: https://github.com/archriss/react-native-snap-carousel/blob/master/doc/PROPS_METHODS_AND_GETTERS.md#methods -- which addresses this issue specifically.

Note: This issue was not evident when the device was in portrait mode as a weird "jiggle" is present when opening the view in portrait mode. That jiggle seems to be a rendering bug. This appears to force the view to re-render (correctly.) Gif with slow animations below:

Without fix

With fix

Tested

• Tested on iOS Simulators and iPhone X

[timarney]

Thanks @joshpc we'll take a look as soon as we can.

[timarney]

Nice :)

Test on device or Android and iOS

Noting this for future reference:

Seems to be okay for our use case.

meliorence/react-native-snap-carousel#492 (comment)