Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Changed accessibilityLabel to accessibiltyHint for CodeInput #847

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

nickmly
Copy link
Contributor

@nickmly nickmly commented Jul 22, 2020

Fixes #843

According to: https://support.google.com/accessibility/android/answer/6378120?hl=en

Defining an android:contentDescription on any EditText or editable TextView may interfere with an accessibility service's ability to describe, navigate, and interact with text that a user enters within the item.

android:contentDescription is mapped to accessibilityLabel on the react native layer, so I changed it to a hint to prevent this warning from coming up

Note: This needs to be tested in Google Play Test Lab

Copy link
Contributor

@henrytao-me henrytao-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM. When TextInput is empty, it reads the hint. When it isn't, it reads the content.

@nickmly nickmly marked this pull request as ready for review July 22, 2020 22:12
@nickmly nickmly requested a review from a team as a code owner July 22, 2020 22:12
@timarney
Copy link
Member

@nickmly let me see if I can get a link for testing with.

@timarney timarney merged commit 0a7de67 into master Jul 24, 2020
@timarney timarney deleted the issue/843/content-description branch July 24, 2020 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextView issue for input of one time code
4 participants