This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Add noStore cacheControl to the diagnosisKeysFile download.
#858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@henrytao-me ☝️ please have look |
henrytao-me
reviewed
Jul 23, 2020
| @@ -38,7 +39,9 @@ class CovidShieldModule(context: ReactApplicationContext) : ReactContextBaseJava | |||
| @ReactMethod | |||
| fun downloadDiagnosisKeysFile(url: String, promise: Promise) { | |||
| promise.launch(this) { | |||
| val request = Request.Builder().url(url).build() | |||
| val request = Request.Builder() | |||
| .cacheControl(CacheControl.Builder().noStore().build()) | |||
There was a problem hiding this comment.
👾 I think we have 8 spaces here instead of 4.
|
Gave CI a nudge - working now. |
timarney
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For added level of security, prevent requests for the diagnosisKeysFile from being cached.