Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Hide chevron on first breadcrumb item #153

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

ethanWallace
Copy link
Collaborator

Summary | Résumé

Add additional CSS and tokens to fix display issue when gcds-breadcrumbs is using hide-canada-link.

Fixes #152

Note: Relies on tokens from cds-snc/gcds-tokens#114

@ethanWallace ethanWallace marked this pull request as ready for review April 25, 2023 16:44
@nmakuch
Copy link
Contributor

nmakuch commented Apr 26, 2023

I'm noticing it's cutting off part of the focus styles on the left side of the first link. Is there any way to fix that? Or are we stuck with it because there's no other way to hide the breadcrumb?

@ethanWallace
Copy link
Collaborator Author

I'm noticing it's cutting off part of the focus styles on the left side of the first link. Is there any way to fix that? Or are we stuck with it because there's no other way to hide the breadcrumb?

The new tokens from @cdssnc/gcds-tokens should have helped with that. Will take a look as to why it isn't working

Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace merged commit 68aab03 into main Apr 26, 2023
@ethanWallace ethanWallace deleted the breadcrumb-display-fix branch April 26, 2023 19:57
@ethanWallace ethanWallace mentioned this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb display issue
3 participants