-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: Update search for mandatory elements alignment #743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ethanWallace does this PR also complete this ticket: cds-snc/design-gc-conception#1364?
Yes it seems like this PR will also cover those design changes |
It looks good so far! There are a few more design specs in ticket cds-snc/design-gc-conception#1364 that I think are not fully captured within this PR yet, namely:
|
@daine I have created a PR for the missing tokens cds-snc/gcds-tokens#389. I have updated the values in the referenced issue to match what has been agreed upon by dev and design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the line directly, but would it be possible to increase the border width for the input on focus from 1px to 2px to be consistent with our other focus states and increase focus visibility?
The rest of the code looks good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the code and acceptance criteria needed for the alignment, it looks good! Nice work, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary | Résumé
For mandatory elements alignment, update the
gcds-search
component's styles.cds-snc/design-gc-conception#1335
Changes
Note: Dependancy on cds-snc/gcds-tokens#382