Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Update search for mandatory elements alignment #743

Merged
merged 10 commits into from
Feb 13, 2025

Conversation

ethanWallace
Copy link
Collaborator

Summary | Résumé

For mandatory elements alignment, update the gcds-search component's styles.

cds-snc/design-gc-conception#1335

Changes

  • Set search to only use 16px font as it is a sub-component of the header
  • Change the border colour to grayscale-100
  • Remove border radius
  • Adjust padding to match font updates
  • Reduce border width to 1px

Note: Dependancy on cds-snc/gcds-tokens#382

@ethanWallace ethanWallace requested review from melaniebmn and daine and removed request for melaniebmn February 3, 2025 13:22
@ethanWallace ethanWallace marked this pull request as ready for review February 3, 2025 13:45
melaniebmn
melaniebmn previously approved these changes Feb 3, 2025
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanWallace does this PR also complete this ticket: cds-snc/design-gc-conception#1364?

@ethanWallace
Copy link
Collaborator Author

does this PR also complete this ticket: cds-snc/design-gc-conception#1364?

Yes it seems like this PR will also cover those design changes

@daine
Copy link
Collaborator

daine commented Feb 6, 2025

It looks good so far! There are a few more design specs in ticket cds-snc/design-gc-conception#1364 that I think are not fully captured within this PR yet, namely:

  • placeholder colour (I commented on the dev ticket and tagged Dylan)
  • button width
  • button and input height

@ethanWallace
Copy link
Collaborator Author

It looks good so far! There are a few more design specs in ticket cds-snc/design-gc-conception#1364 that I think are not fully captured within this PR yet, namely:

  • placeholder colour (I commented on the dev ticket and tagged Dylan)
  • button width
  • button and input height

@daine I have created a PR for the missing tokens cds-snc/gcds-tokens#389. I have updated the values in the referenced issue to match what has been agreed upon by dev and design.

Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the line directly, but would it be possible to increase the border width for the input on focus from 1px to 2px to be consistent with our other focus states and increase focus visibility?

The rest of the code looks good to go.

daine
daine previously approved these changes Feb 12, 2025
Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the code and acceptance criteria needed for the alignment, it looks good! Nice work, thank you!

melaniebmn
melaniebmn previously approved these changes Feb 13, 2025
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace dismissed stale reviews from melaniebmn and daine via 231c2af February 13, 2025 17:52
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace merged commit 3697498 into main Feb 13, 2025
3 checks passed
@ethanWallace ethanWallace deleted the style/update-search branch February 13, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants