Skip to content

Commit

Permalink
refactor: adjust mobile padding for footer bands
Browse files Browse the repository at this point in the history
  • Loading branch information
melaniebmn committed Feb 13, 2025
1 parent ef70928 commit aa42cbb
Show file tree
Hide file tree
Showing 8 changed files with 36 additions and 18 deletions.
12 changes: 9 additions & 3 deletions build/figma/figma.tokens.json
Original file line number Diff line number Diff line change
Expand Up @@ -2462,8 +2462,14 @@
"footer": {
"band": {
"padding": {
"value": "2.25rem 0",
"type": "spacing"
"desktop": {
"value": "2.25rem 0",
"type": "spacing"
},
"mobile": {
"value": "1.5rem 0",
"type": "spacing"
}
}
},
"container": {
Expand Down Expand Up @@ -2560,7 +2566,7 @@
"listitem": {
"before": {
"margin": {
"value": "0 1.125rem",
"value": "0 1.5rem",
"type": "spacing"
}
}
Expand Down
5 changes: 3 additions & 2 deletions build/web/css/components.css
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@
--gcds-file-uploader-hover-button-background: #d7e5f5;
--gcds-file-uploader-active-button-background: #000000;
--gcds-file-uploader-active-button-text: #ffffff;
--gcds-footer-band-padding: 2.25rem 0;
--gcds-footer-band-padding-desktop: 2.25rem 0;
--gcds-footer-band-padding-mobile: 1.5rem 0;
--gcds-footer-container-margin: 0 auto;
--gcds-footer-container-width: 71.25rem;
--gcds-footer-contextual-background: #33465c;
Expand All @@ -320,7 +321,7 @@
--gcds-footer-main-nav-first-after-width: 2.25rem;
--gcds-footer-main-text: #ffffff;
--gcds-footer-sub-background: #f1f2f3;
--gcds-footer-sub-listitem-before-margin: 0 1.125rem;
--gcds-footer-sub-listitem-before-margin: 0 1.5rem;
--gcds-footer-sub-signature-width: 10.25rem;
--gcds-footer-sub-signature-min-width: auto;
--gcds-footer-sub-signature-max-height: 2.4375rem;
Expand Down
5 changes: 3 additions & 2 deletions build/web/css/components/footer.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
*/

:root {
--gcds-footer-band-padding: 2.25rem 0;
--gcds-footer-band-padding-desktop: 2.25rem 0;
--gcds-footer-band-padding-mobile: 1.5rem 0;
--gcds-footer-container-margin: 0 auto;
--gcds-footer-container-width: 71.25rem;
--gcds-footer-contextual-background: #33465c;
Expand All @@ -19,7 +20,7 @@
--gcds-footer-main-nav-first-after-width: 2.25rem;
--gcds-footer-main-text: #ffffff;
--gcds-footer-sub-background: #f1f2f3;
--gcds-footer-sub-listitem-before-margin: 0 1.125rem;
--gcds-footer-sub-listitem-before-margin: 0 1.5rem;
--gcds-footer-sub-signature-width: 10.25rem;
--gcds-footer-sub-signature-min-width: auto;
--gcds-footer-sub-signature-max-height: 2.4375rem;
Expand Down
5 changes: 3 additions & 2 deletions build/web/css/tokens.css
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,8 @@
--gcds-file-uploader-hover-button-background: #d7e5f5;
--gcds-file-uploader-active-button-background: #000000;
--gcds-file-uploader-active-button-text: #ffffff;
--gcds-footer-band-padding: 2.25rem 0;
--gcds-footer-band-padding-desktop: 2.25rem 0;
--gcds-footer-band-padding-mobile: 1.5rem 0;
--gcds-footer-container-margin: 0 auto;
--gcds-footer-container-width: 71.25rem;
--gcds-footer-contextual-background: #33465c;
Expand All @@ -480,7 +481,7 @@
--gcds-footer-main-nav-first-after-width: 2.25rem;
--gcds-footer-main-text: #ffffff;
--gcds-footer-sub-background: #f1f2f3;
--gcds-footer-sub-listitem-before-margin: 0 1.125rem;
--gcds-footer-sub-listitem-before-margin: 0 1.5rem;
--gcds-footer-sub-signature-width: 10.25rem;
--gcds-footer-sub-signature-min-width: auto;
--gcds-footer-sub-signature-max-height: 2.4375rem;
Expand Down
5 changes: 3 additions & 2 deletions build/web/scss/components.scss
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,8 @@ $gcds-file-uploader-focus-button-outline-offset: 0.125rem;
$gcds-file-uploader-hover-button-background: #d7e5f5;
$gcds-file-uploader-active-button-background: #000000;
$gcds-file-uploader-active-button-text: #ffffff;
$gcds-footer-band-padding: 2.25rem 0;
$gcds-footer-band-padding-desktop: 2.25rem 0;
$gcds-footer-band-padding-mobile: 1.5rem 0;
$gcds-footer-container-margin: 0 auto;
$gcds-footer-container-width: 71.25rem;
$gcds-footer-contextual-background: #33465c;
Expand All @@ -318,7 +319,7 @@ $gcds-footer-main-nav-first-after-border-width: 0.25rem;
$gcds-footer-main-nav-first-after-width: 2.25rem;
$gcds-footer-main-text: #ffffff;
$gcds-footer-sub-background: #f1f2f3;
$gcds-footer-sub-listitem-before-margin: 0 1.125rem;
$gcds-footer-sub-listitem-before-margin: 0 1.5rem;
$gcds-footer-sub-signature-width: 10.25rem;
$gcds-footer-sub-signature-min-width: auto;
$gcds-footer-sub-signature-max-height: 2.4375rem;
Expand Down
5 changes: 3 additions & 2 deletions build/web/scss/components/footer.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@

// Do not edit directly, this file was auto-generated.

$gcds-footer-band-padding: 2.25rem 0;
$gcds-footer-band-padding-desktop: 2.25rem 0;
$gcds-footer-band-padding-mobile: 1.5rem 0;
$gcds-footer-container-margin: 0 auto;
$gcds-footer-container-width: 71.25rem;
$gcds-footer-contextual-background: #33465c;
Expand All @@ -17,7 +18,7 @@ $gcds-footer-main-nav-first-after-border-width: 0.25rem;
$gcds-footer-main-nav-first-after-width: 2.25rem;
$gcds-footer-main-text: #ffffff;
$gcds-footer-sub-background: #f1f2f3;
$gcds-footer-sub-listitem-before-margin: 0 1.125rem;
$gcds-footer-sub-listitem-before-margin: 0 1.5rem;
$gcds-footer-sub-signature-width: 10.25rem;
$gcds-footer-sub-signature-min-width: auto;
$gcds-footer-sub-signature-max-height: 2.4375rem;
Expand Down
5 changes: 3 additions & 2 deletions build/web/scss/tokens.scss
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,8 @@ $gcds-file-uploader-focus-button-outline-offset: 0.125rem;
$gcds-file-uploader-hover-button-background: #d7e5f5;
$gcds-file-uploader-active-button-background: #000000;
$gcds-file-uploader-active-button-text: #ffffff;
$gcds-footer-band-padding: 2.25rem 0;
$gcds-footer-band-padding-desktop: 2.25rem 0;
$gcds-footer-band-padding-mobile: 1.5rem 0;
$gcds-footer-container-margin: 0 auto;
$gcds-footer-container-width: 71.25rem;
$gcds-footer-contextual-background: #33465c;
Expand All @@ -478,7 +479,7 @@ $gcds-footer-main-nav-first-after-border-width: 0.25rem;
$gcds-footer-main-nav-first-after-width: 2.25rem;
$gcds-footer-main-text: #ffffff;
$gcds-footer-sub-background: #f1f2f3;
$gcds-footer-sub-listitem-before-margin: 0 1.125rem;
$gcds-footer-sub-listitem-before-margin: 0 1.5rem;
$gcds-footer-sub-signature-width: 10.25rem;
$gcds-footer-sub-signature-min-width: auto;
$gcds-footer-sub-signature-max-height: 2.4375rem;
Expand Down
12 changes: 9 additions & 3 deletions tokens/components/footer/tokens.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@
"footer": {
"band": {
"padding": {
"value": "{spacing.450.value} 0",
"type": "spacing"
"desktop": {
"value": "{spacing.450.value} 0",
"type": "spacing"
},
"mobile": {
"value": "{spacing.300.value} 0",
"type": "spacing"
}
}
},
"container": {
Expand Down Expand Up @@ -102,7 +108,7 @@
"listitem": {
"before": {
"margin": {
"value": "0 {spacing.225.value}",
"value": "0 {spacing.300.value}",
"type": "spacing"
}
}
Expand Down

0 comments on commit aa42cbb

Please sign in to comment.