Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update search component tokens #382

Merged
merged 2 commits into from
Jan 30, 2025
Merged

feat: Update search component tokens #382

merged 2 commits into from
Jan 30, 2025

Conversation

ethanWallace
Copy link
Collaborator

@ethanWallace ethanWallace commented Jan 29, 2025

Summary | Résumé

To match requirements for mandatory elements alignment, update search component tokens.

Search component tokens that are no longer in use will be removed in a separate pull request tagged remove: once this pull request has been merged.

cds-snc/design-gc-conception#1335

Changes

  • Set search to only use 16px font as it is a sub-component of the header
  • Change the border colour to grayscale-100
  • Remove border radius
  • Adjust padding to match font updates
  • Reduce border width to 1px

To be used in cds-snc/gcds-components#743

@ethanWallace ethanWallace changed the title feat: Update search font feat: Update search component tokens Jan 29, 2025
melaniebmn
melaniebmn previously approved these changes Jan 29, 2025
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace
Copy link
Collaborator Author

Just keeping this open for now. Design might make a slight change to the button padding.

Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace merged commit 5e624d1 into main Jan 30, 2025
1 check passed
@ethanWallace ethanWallace deleted the feat/search-font branch January 30, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants