Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile padding for footer bands #403

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

melaniebmn
Copy link
Collaborator

Summary | Résumé

Two more small token updates for the footer after some more talks with the design team. We are slightly adjusting the mobile padding for the footer bands and increasing the spacing between the links in the sub band to match the other link spacing.

Copy link
Collaborator

@daine daine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change the type from refactor to something else as this changes the values?

@melaniebmn melaniebmn changed the title refactor: adjust mobile padding for footer bands feat: add mobile padding for footer bands Feb 17, 2025
@melaniebmn melaniebmn requested a review from daine February 17, 2025 16:35
ethanWallace
ethanWallace previously approved these changes Feb 17, 2025
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melaniebmn melaniebmn merged commit 7d5e692 into main Feb 19, 2025
1 check passed
@melaniebmn melaniebmn deleted the chore/adjust-footer-band-padding-mobile branch February 19, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants