Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y fable/lexical prototype #1720

Draft
wants to merge 85 commits into
base: main
Choose a base branch
from
Draft

A11y fable/lexical prototype #1720

wants to merge 85 commits into from

Conversation

andrewleith
Copy link
Member

@andrewleith andrewleith commented Nov 14, 2023 •
edited
Loading

Summary | Résumé

PR to create a prototype for lexical for fable testing. This prototype enhances the current implementation, adding a few extra a11y features:

  • Tooltips/aria-label's on the toolbar items
  • Keyboard-specific instructions for screen-reader users:
    • When focus lands on the toolbar it will say:

      • Template toolbar: press the left and right arrow keys to see the formatting options; press tab to enter the content area

    • When focus lands on the content area it will say:

      • Content editor: edit or create your content here. To apply formatting, the desired text and press shift+tab to return to the toolbar and select an option. You can also use markdown formatting directly in the editor.

@andrewleith
feat(lexical): add lexical to admin and try it out on the welcome ppage
d89d1af
@andrewleith
chore(formatting): add missing semi-colon
b6fbce9
@andrewleith
chore: remove 1st version of lexical
59e6089
@andrewleith
chore: add generated assets
35d0287
@andrewleith
chore: update react, react-dom; add webpack support for typescript
4208052
@andrewleith
chore(test): fix test -remove expression that linter says conditional…
1ae16b9 
… will always be true
@andrewleith
chore: formatting
634313c
@andrewleith
Merge branch 'main' into experiment/use-lexical-editor
2b75992
@andrewleith
feat(lexical): make react app into a jinja component 🤯
114fbc0
@andrewleith
chore: formatting
26a667f
@andrewleith
chore: remove unused imports
a1f5828
@andrewleith
chore: formatting
8c8f392
@andrewleith
chore: removed unused images
e441293
@andrewleith
chore: remove more unused images
61e92cc
@andrewleith
chore: remove unused files
6ec9356
@andrewleith
style(gulp): make toolbar icons from fontawesome available
bf8f7b6
@andrewleith
chore(build): re-gen js and css
ef3f20b
@andrewleith
style(lexical): update toolbar css, use FA icons for toolbar
e0f045b
@andrewleith
chore: rebuild static assets
c32f29d
@andrewleith
chore: remove unsused id in query string
213705b
@andrewleith
feat(tabbing): EXPERIMENTAL: add support for tabbing to indent
63415d0
@andrewleith
feat(lexical): add HR support
2529cb4
@andrewleith
fix(lexical): fix heading structure to use h1/h2 like notify already …
8fcf7a8 
…does (instead of h2/h3 like forms did)
@andrewleith
chore: asset update
9302080
@andrewleith
feat(headings): only allow 2 levels of headings when typing out markdown
1df9979
@andrewleith
feat(toolbar): make toolbar stay in viewport when scrolling
2262699
@andrewleith
style(toolbar): add missing icon
1bcb443
@andrewleith
a11y: fix up labels on various elements; disabled tabIndentationPlugin
c409792
@andrewleith
style(link editor): remove blue color
360491b
@andrewleith
feat(fable test): add a test page for fable testing; this commit shou…
77dfb76 
…ld be reverted later ↩️
@github-actions GitHub Actions
Copy link

🧪 Review environment

https://jv7lvesgr5gmaxzx7wm5b2da740lqjsp.lambda-url.ca-central-1.on.aws/

andrewleith and others added 17 commits January 12, 2024 19:32
@andrewleith
chore: regen lexical
d47f82b
@andrewleith
chore: add types
f4b2934
@andrewleith
chore: re-gen lexical
c5998c7
@andrewleith
feat(lexical): add os-specific shortcut keys; add help modal with ins…
375f1c9 
…tructions
@andrewleith
fix(numbered list): add keyboard selection fix for numbered list
e35d8d3
@andrewleith
chore: regen lexical
d2ce76a
@andrewleith
Merge branch 'main' into a11y-fable/lexical-prototype
8bc754e
@amazingphilippe
translations
027f6d4
@andrewleith
a11y(announce): announce formatting changes
29484b9
@andrewleith
a11y(link editor): open modal when inserting link; enhance input labe…
d531ca4 
…l to indicate what it is and how to close it
@andrewleith
chore: formatting
5f549ec
@andrewleith
chore: re-gen lexical
4e6dccf
@andrewleith
Merge branch 'main' into a11y-fable/lexical-prototype
63303d3
@andrewleith
fix(selection bug): properly insert bulleted and numbered lists with …
01db86d 
…keyboard selection
@andrewleith
Merge branch 'main' into a11y-fable/lexical-prototype
a06b200
@andrewleith
chore: formatting
d33eed7
@andrewleith
chore: re-gen lexical
1c90a07
@jzbahrai jzbahrai marked this pull request as draft May 1, 2024 19:11
@github-actions GitHub Actions
Copy link

🧪 Review environment

https://psnl6l6cn7jed4mc766665u6ni0mpacs.lambda-url.ca-central-1.on.aws/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewleith @amazingphilippe